-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactivate Couchbase for SB3 #27972
Reactivate Couchbase for SB3 #27972
Conversation
Hi @kamilkrzywanski you can enable CI by removing:
And:
|
@mshima with your sort fix now fails 2 checks instead of 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snapshots should be updated with npm run update-snapshots
.
.../templates/src/test/java/_package_/_entityPackage_/web/rest/_entityClass_ResourceIT.java.ejs
Outdated
Show resolved
Hide resolved
kkrzywanski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
You can undo last 2 commits. |
If you're able to do it feel free, otherwise will do it later. |
The sign issue can be ignore since we can remove the contributor when squashing, but snapshots should be updated. |
@kamilkrzywanski please run |
For some reason running test using prod profile fails: Any idea? |
@mshima idk, will inwestigate on wednesday :) If you have free time then my hint is: when you put sleep before call api then test pass :) |
@mshima Looks similar. probably not jhipster implementation issue :) |
Let’s merge and check the daily builds tomorrow. |
$100 bug bounty claim https://opencollective.com/generator-jhipster/expenses/229701 |
@kamilkrzywanski can you add the sleep? |
@mshima |
Great thanks. |
@kamilkrzywanski approved |
Fix for issue #27490
Single tests might fails yet but most of them should be already is green :)
Fixes #26577