Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivate Couchbase for SB3 #27972

Merged
merged 26 commits into from
Nov 28, 2024
Merged

Reactivate Couchbase for SB3 #27972

merged 26 commits into from
Nov 28, 2024

Conversation

kamilkrzywanski
Copy link
Contributor

@kamilkrzywanski kamilkrzywanski commented Nov 23, 2024

Fix for issue #27490
Single tests might fails yet but most of them should be already is green :)

Fixes #26577

@mshima
Copy link
Member

mshima commented Nov 23, 2024

Hi @kamilkrzywanski you can enable CI by removing:

"disabled": "needs adjusts for sb3",

And:
"disabled": "needs adjusts for sb3",

@kamilkrzywanski
Copy link
Contributor Author

@mshima with your sort fix now fails 2 checks instead of 1

@DanielFran DanielFran changed the title fix #27490 - remove old walkaround Reactivate Couchbase for SB3 Nov 25, 2024
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snapshots should be updated with npm run update-snapshots.

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ kamilkrzywanski
✅ mshima
❌ kkrzywanski


kkrzywanski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mshima
Copy link
Member

mshima commented Nov 25, 2024

You can undo last 2 commits. git reset @~2 and commit with correct user.

@kamilkrzywanski
Copy link
Contributor Author

If you're able to do it feel free, otherwise will do it later.

@mshima
Copy link
Member

mshima commented Nov 25, 2024

The sign issue can be ignore since we can remove the contributor when squashing, but snapshots should be updated.

@github-actions github-actions bot added the theme: dependencies Pull requests that update a dependency file label Nov 25, 2024
@mshima
Copy link
Member

mshima commented Nov 25, 2024

@kamilkrzywanski please run npx esmocha .blueprint --update-snapshot.
Snapshots inside .blueprint are missing.
Thanks.

@kamilkrzywanski
Copy link
Contributor Author

Commited, I'm hope it's gonna work now :)
image

@mshima
Copy link
Member

mshima commented Nov 25, 2024

For some reason running test using prod profile fails:
https://github.com/hipster-labs/jhipster-daily-builds/actions/runs/12018296891/job/33503896516

Any idea?

@kamilkrzywanski
Copy link
Contributor Author

@mshima idk, will inwestigate on wednesday :) If you have free time then my hint is: when you put sleep before call api then test pass :)
image

@DanielFran DanielFran marked this pull request as draft November 27, 2024 08:42
@kamilkrzywanski
Copy link
Contributor Author

kamilkrzywanski commented Nov 27, 2024

@mshima
spring-projects/spring-data-couchbase#1893
spring-projects/spring-data-couchbase#1797

Looks similar. probably not jhipster implementation issue :)
What do you think about it?

@mshima
Copy link
Member

mshima commented Nov 28, 2024

Let’s merge and check the daily builds tomorrow.

@mshima mshima marked this pull request as ready for review November 28, 2024 16:28
@mshima mshima merged commit eb77cde into jhipster:main Nov 28, 2024
66 of 67 checks passed
@kamilkrzywanski
Copy link
Contributor Author

@mshima
Copy link
Member

mshima commented Nov 29, 2024

@mshima idk, will inwestigate on wednesday :) If you have free time then my hint is: when you put sleep before call api then test pass :) image

@kamilkrzywanski can you add the sleep?

@kamilkrzywanski
Copy link
Contributor Author

@mshima
Probably I found better solution, but on this weekend i'm bussy, will commit on Sunday/Monday :)

@mshima
Copy link
Member

mshima commented Nov 29, 2024

Great thanks.

@DanielFran
Copy link
Member

kamilkrzywanski added a commit to kamilkrzywanski/generator-jhipster that referenced this pull request Nov 30, 2024
kamilkrzywanski added a commit to kamilkrzywanski/generator-jhipster that referenced this pull request Nov 30, 2024
@kamilkrzywanski
Copy link
Contributor Author

@mshima as told, PR created #28039

kamilkrzywanski added a commit to kamilkrzywanski/generator-jhipster that referenced this pull request Dec 1, 2024
mshima pushed a commit that referenced this pull request Dec 1, 2024
* Isue #27972 last tests fix

* Isue #27972 last tests fix

* Isue #27972 last tests fix
@mraible mraible added this to the 8.8.0 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to login neither to register monolith + couchbase
5 participants