Liquibase foreign key relationship column names

[OmarHawk]

Fixes #27598 and adds additional conditions to the existing tests (which were missing)

---

Please make sure the below checklist is followed for Pull Requests.

• All continuous integration tests are green
• Tests are added where necessary
• The JDL part is updated if necessary
• jhipster-online is updated if necessary
• Documentation is added/updated where necessary
• Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

[mraible]

Can you please run npm run update-snapshots and commit/push the changes?

[OmarHawk]

at the moment, there is no change in the snapshots as I haven't changed anything in the test case (jdl definition) itself, I just added additional conditions into the tests to verify the output of the current tests.

But I can adjust the template / generation logic now, which would then in turn actually change the snapshots

[mraible]

@OmarHawk If you run npm test, you should see the errors. Updating the snapshots might fix them, that's why I suggested it.

[OmarHawk]

ok, understood, but I considered that already. :-)

[OmarHawk]

I have moved the working logic from the add constraints into an own partial template, and use that to be included in both the add and update contraints

[mshima]

Liquibase changelog should be polished, you can see in ng-default sample compare:

a/src/main/resources/config/liquibase/changelog/20160208210109_added_entity_constraints_TestCustomTableName.xml
  @@ -10,6 +10,9 @@
       -->
       <changeSet id="20160208210109-2" author="jhipster">
   
  +
  +
  +
           <addForeignKeyConstraint baseColumnNames="test_entity_id"
                                    baseTableName="test_custom_table_name_entity"
                                    constraintName="fk_test_custom_table_name_entity__test_entity_id"
  diff --git b/src/main/resources/config/liquibase/changelog/20160208210110_added_entity_constraints_TestEntity.xml a/src/main/resources/config/liquibase/changelog/20160208210110_added_entity_constraints_TestEntity.xml
  index e4385fd..dcb84bf 100644
  --- b/src/main/resources/config/liquibase/changelog/20160208210110_added_entity_constraints_TestEntity.xml
  +++ a/src/main/resources/config/liquibase/changelog/20160208210110_added_entity_constraints_TestEntity.xml
  @@ -10,6 +10,9 @@
       -->
       <changeSet id="20160208210110-2" author="jhipster">
   
  +
  +
  +
           <addForeignKeyConstraint baseColumnNames="user_one_to_many_id"
                                    baseTableName="test_entity"
                                    constraintName="fk_test_entity__user_one_to_many_id"
  @@ -37,5 +40,8 @@

[OmarHawk]

Liquibase changelog should be polished, you can see in ng-default sample compare:

I see, will fix it :-)

[OmarHawk]

I do have now less empty lines, do you think, it is alright @mshima? Or does it have to be the exact same way as before?

[mshima]

I think we should keep the same blank lines to avoid unnecessary diff when upgrading applications, specially changelogs.

[OmarHawk]

I think we should keep the same blank lines to avoid unnecessary diff when upgrading applications, specially changelogs.

Added the empty line again in the add constraints changelog file. Hope it looks alright now :-)

[OmarHawk]

ah, damn, as soon, as I add the empty line into the for loop, it creates some additonal lines for unhandled relationships. So I would need to pass a paramater to add additional empty lines into the new template just for the add case. I don't think, that is a good idea. I'd rather keep it now clean and without these empty lines at all.

[OmarHawk]

Reverted the last change regarding the empty line in the add template - please check the Merge Request again @DanielFran, @mshima , whether you are OK with it: I really don't think it makes sense to have a parameter named createEmptyLines: true as part of a template in order to have empty lines in add case, but not in the update case.
The benefit of having it combined into one template is larger than having some (even less!) useless empty lines.

[mshima]

Updated files are not overridden.
There is no problem on changing format.

[OmarHawk]

ok, interesting that after the change it shows no changes anymore now. I'd have assumed that with adding the empty lines within the template, it would now produce empty lines in the update constraint files...

[OmarHawk]

I'll update the snapshots once more, if you are OK with it - then the MR should become green :-)

[mshima]

@OmarHawk projects are identical now, should be ok to merge.
Please update snapshots.

[OmarHawk]

Done and squashed the excess commits so that the merge contains only a single commit and looks cleaner.

[OmarHawk]

Hope it is alright to claim this: https://opencollective.com/generator-jhipster/expenses/225277

[DanielFran]

@OmarHawk approved