cleanup jdl and reduce dependency on jhipster #27151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielFran
approved these changes
Sep 2, 2024
Tcharl
requested changes
Sep 3, 2024
| @@ -91,12 +85,12 @@ describe('jdl - OptionConverter', () => { | |||
| before(() => { | |||
| convertedOptions = convertOptions({}, [ | |||
| { | |||
| optionValues: [MAPSTRUCT, COUCHBASE], | |||
| optionValues: ['mapstruct', 'elasticsearch'], | |||
There was a problem hiding this comment.
More consistency is more valuable than decoupling. Jdl should be split into generator so each part create the dsl. Jdl should not be decoupled from generator but instead integrated into each of them
There was a problem hiding this comment.
Imho, this pr comes with regressions : using constants helps folding to provide complete feature enhancement. This pr breaks that useful feature.
I do not see any added value decoupling jdl and generator as the main end user usage is the jdl triggering generator : jdl should be modularized and fragmented into generators instead of being decoupled and only covering partial coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #27136
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.