-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate docker compose #27062
integrate docker compose #27062
Conversation
13b558c
to
79bbfa7
Compare
Added bug bounty to the issue this fixes. |
8af2f3f
to
c98676d
Compare
Is there anything I can do to help move this along? |
5b72bd6
to
1b0fa44
Compare
@mraible its not clear to me how to test it. see #24469 (comment) |
I know PostgreSQL is broken due to missing password. |
We could remove the step to start Docker containers before the app starts. Maybe even remove the scripts to start containers since it'll be automatic.
|
We test compiled jar for monoliths and docker images for microservices. I think this behavior is correct because the production jar and docker images are the most important. To test docker compose integration we should run using |
I’ve reduced the log to warn, it’s too verbose in CI. |
microservices now depends on the database compose file instead of services. |
I tested again with microservices and confirmed everything starts and works as expected. Nice work, @mshima! |
Fixes #24469.
Please make sure the below checklist is followed for Pull Requests.