Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove close button from the header. #26294

Merged
merged 2 commits into from
May 29, 2024
Merged

remove close button from the header. #26294

merged 2 commits into from
May 29, 2024

Conversation

mshima
Copy link
Member

@mshima mshima commented May 28, 2024

Related to SonarSource/sonar-html#291 (comment).

The dismiss button in the header is duplicated of the cancel button action.
We can remove the button from the header or ignore the error.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima marked this pull request as ready for review May 28, 2024 21:20
@mshima mshima changed the title remove close button in the header. remove close button from the header. May 28, 2024
@DanielFran DanielFran merged commit 48e562d into main May 29, 2024
43 checks passed
@DanielFran DanielFran deleted the cleanup-angular branch May 29, 2024 12:15
@mraible mraible added this to the 8.5.0 milestone May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants