Sonar: This block of commented-out lines of code should be removed #26272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshima
reviewed
May 26, 2024
.../templates/src/test/java/_package_/_entityPackage_/web/rest/_entityClass_ResourceIT.java.ejs
Outdated
Show resolved
Hide resolved
.../templates/src/test/java/_package_/_entityPackage_/web/rest/_entityClass_ResourceIT.java.ejs
Outdated
Show resolved
Hide resolved
.../templates/src/test/java/_package_/_entityPackage_/web/rest/_entityClass_ResourceIT.java.ejs
Outdated
Show resolved
Hide resolved
.../templates/src/test/java/_package_/_entityPackage_/web/rest/_entityClass_ResourceIT.java.ejs
Outdated
Show resolved
Hide resolved
| * Validate the id for MapsId, the ids must be same | ||
| * Uncomment the following line for assertion. However, please note that there is a known issue and uncommenting will fail the test. | ||
| * Please look at https://github.com/jhipster/generator-jhipster/issues/9100. You can modify this test as necessary. | ||
| * assertThat(test<%= entityClass %>.get<%= primaryKey.nameCapitalized %>()).isEqualTo(test<%= entityClass %>.get<%= mapsIdEntity %>().get<%= primaryKey.nameCapitalized %>()); |
There was a problem hiding this comment.
I wonder if the issue still applies.
There was a problem hiding this comment.
…tyPackage_/web/rest/_entityClass_ResourceIT.java.ejs Co-authored-by: Marcelo Shima <[email protected]>
…tyPackage_/web/rest/_entityClass_ResourceIT.java.ejs Co-authored-by: Marcelo Shima <[email protected]>
…tyPackage_/web/rest/_entityClass_ResourceIT.java.ejs Co-authored-by: Marcelo Shima <[email protected]>
…tyPackage_/web/rest/_entityClass_ResourceIT.java.ejs Co-authored-by: Marcelo Shima <[email protected]>
DanielFran
approved these changes
May 27, 2024
|
Before |
|
@mshima @DanielFran it worked 🙂 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should remove a lot of Sonar issues:
This block of commented-out lines of code should be removedlike https://sonarcloud.io/project/issues?impactSoftwareQualities=MAINTAINABILITY&resolved=false&id=jhipster-sample-application&open=AY92SBLBzvwT9Xfig0r_Remove this unused "testMapsIdGrandchildEntityWithoutDTO" local variablelike https://sonarcloud.io/project/issues?impactSoftwareQualities=MAINTAINABILITY&resolved=false&id=jhipster-sample-application&open=AY92SBLBzvwT9Xfig0r-Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.