More type checking #26269
Merged
More type checking #26269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshima
reviewed
May 25, 2024
mshima
reviewed
May 25, 2024
mshima
reviewed
May 25, 2024
mshima
reviewed
May 25, 2024
mshima
reviewed
May 26, 2024
| @@ -50,7 +50,7 @@ type JDLOptionHolder = JDLObject | JDLApplication; | |||
| * @param jdlOptionHolder - a JDL object (a JDLObject or a JDLApplication) containing the options. | |||
| * @return {Map<String, Object>} a map having for keys entity names and for values the JSON option contents. | |||
| */ | |||
| export function convert(jdlOptionHolder: JDLOptionHolder): Map<string, any> { | |||
| export function convert(jdlOptionHolder?: JDLOptionHolder): Map<string, any> { | |||
There was a problem hiding this comment.
Not optional
Suggested change
| export function convert(jdlOptionHolder?: JDLOptionHolder): Map<string, any> { | |
| export function convert(jdlOptionHolder: JDLOptionHolder): Map<string, any> { |
| @@ -34,15 +34,15 @@ export default { convertValidations }; | |||
| * @return the converted JDLValidations. | |||
| */ | |||
| export function convertValidations( | |||
| validations: ParsedJDLValidation[], | |||
| constantValueGetter: (constant: string) => string | number | boolean | RegExp, | |||
| validations?: ParsedJDLValidation[], | |||
There was a problem hiding this comment.
Not optional
Suggested change
| validations?: ParsedJDLValidation[], | |
| validations: ParsedJDLValidation[], |
jdl/jdl-importer.ts
Outdated
| @@ -49,7 +51,7 @@ const { APPLICATION_TYPE, BASE_NAME } = OptionNames; | |||
| * @returns {Object} a JDL importer. | |||
| * @throws {Error} if files aren't passed. | |||
| */ | |||
| export function createImporterFromFiles(files, configuration?: any) { | |||
| export function createImporterFromFiles(files?, configuration?: any) { | |||
There was a problem hiding this comment.
Suggested change
| export function createImporterFromFiles(files?, configuration?: any) { | |
| export function createImporterFromFiles(files?, configuration: any) { |
mshima
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to #26114
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.