-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sonar: This block of commented-out lines of code should be removed #26268
Conversation
*/ | ||
@SuppressWarnings("java:S125") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove the commented code.
I think we can do something like:
*/ | |
@SuppressWarnings("java:S125") | |
* | |
* @see <a href="https://github.com/jhipster/generator-jhipster/tree/v<%- jhipsterVersion %>/generators/gatling#logging-tips">Logging tips</a> | |
*/ |
Add a README.md in https://github.com/jhipster/generator-jhipster/tree/main/generators/gatling with:
## Logging tips
```
LoggerContext context = (LoggerContext) LoggerFactory.getILoggerFactory();
{
// Log all HTTP requests
//context.getLogger("io.gatling.http").setLevel(Level.valueOf("TRACE"));
// Log failed HTTP requests
//context.getLogger("io.gatling.http").setLevel(Level.valueOf("DEBUG"));
}
```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mshima ok let's try this
Co-authored-by: Marcelo Shima <[email protected]>
Co-authored-by: Matt Raible <[email protected]>
Should remove a lot of Sonar code smells like https://sonarcloud.io/project/issues?impactSoftwareQualities=MAINTAINABILITY&resolved=false&id=jhipster-sample-application&open=AY92SBeNzvwT9Xfig0tw
Related to #25231
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.