Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix daily builds errors. downgrade gradle openapi generator plugin. #26260

Merged
merged 2 commits into from
May 24, 2024

Conversation

mshima
Copy link
Member

@mshima mshima commented May 24, 2024

gradle openapi generator v7.6.0 is correctly working with Gatling only.
downgrade to v7.5.0.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima marked this pull request as draft May 24, 2024 14:17
@mshima mshima changed the title add gradle sample with enableSwaggerCodegen fix daily builds errors May 24, 2024
@mshima mshima marked this pull request as ready for review May 24, 2024 16:15
@mshima mshima marked this pull request as draft May 24, 2024 16:22
@mshima
Copy link
Member Author

mshima commented May 24, 2024

#26203 was merged same day jdl daily-builds changes was merged 😒.
I was looking for a generation error, but was a dependency error.

@mshima
Copy link
Member Author

mshima commented May 24, 2024

@mshima I see that we were not using gradle plugin... Did you test with gradle plugin 7.6.0?

@DanielFran we are using gradle plugin, we were reusing maven-plugin version since it matches.
I've added a specific version for gradle plugin now.

So maven is v7.6.0 and gradle is been downgrade to v7.5.0

@mshima
Copy link
Member Author

mshima commented May 24, 2024

For reference: OpenAPITools/openapi-generator#18753

@mshima mshima assigned mshima and unassigned mshima May 24, 2024
@mshima mshima marked this pull request as ready for review May 24, 2024 16:47
@mshima mshima changed the title fix daily builds errors fix daily builds errors. downgrade gradle openapi generator plugin. May 24, 2024
@DanielFran DanielFran enabled auto-merge May 24, 2024 16:51
@DanielFran DanielFran merged commit de40b11 into jhipster:main May 24, 2024
52 checks passed
@mshima mshima deleted the gradle-openapi-generator branch May 24, 2024 17:01
@mraible mraible added this to the 8.5.0 milestone May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants