Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonar: Rename 'user' which hides the field declared at line 80 #26241

Merged
merged 1 commit into from
May 23, 2024

Conversation

qmonmert
Copy link
Contributor

Related to #26225 #25231

Fix https://sonarcloud.io/project/issues?impactSoftwareQualities=MAINTAINABILITY&resolved=false&id=jhipster-sample-application&open=AY92SBKhzvwT9Xfig0r5

Before
image

After
TODO:


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@qmonmert qmonmert requested review from DanielFran and mshima May 23, 2024 13:59
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts with #26240

@qmonmert
Copy link
Contributor Author

@mshima I will rebase when your PR will be merged

@mshima mshima enabled auto-merge (squash) May 23, 2024 17:28
@mshima mshima merged commit 886f367 into jhipster:main May 23, 2024
52 checks passed
@qmonmert
Copy link
Contributor Author

@mshima @DanielFran

image

@mraible mraible added this to the 8.5.0 milestone May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants