Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(generator): default maven-resources-plugin to the spring-boot-parent definition #25980

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

timothystone
Copy link
Contributor

@timothystone timothystone commented Apr 28, 2024

Update the generator templates for Gradle and Maven to use the Spring default delimiter of the commercial-at sign (@). Remove the JHipster configuration of the delimiter and default to Spring Boot Parent's configuration and allow it to inherit. This will properly scope the config/bootstrap*.yml and allow Spring Boot's root resources definition to handle the **/application*.yml files.

Fixes #25979


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

…spring-boot-parent definition

Update the generator templates for Gradle and Maven to use the Spring default delimiter of the
commercial-at sign (`@`). Remove the JHipster configuration of the delimiter and default to Spring
Boot Parent's configuration and allow it to inherit. This will properly scope the config/bootstrap*.yml and
allow Spring Boot's root resources definition to handle the **/application*.yml files.

Fixes jhipster#25979
@timothystone timothystone force-pushed the fix/spring-profiles-active branch from ad9304f to 117f154 Compare April 28, 2024 19:30
@timothystone timothystone changed the title fix(generator): default the maven-resources-plugin definition to the spring-boot-parent definition build(generator): default the maven-resources-plugin definition to the spring-boot-parent definition Apr 28, 2024
@timothystone timothystone changed the title build(generator): default the maven-resources-plugin definition to the spring-boot-parent definition build(generator): default maven-resources-plugin to the spring-boot-parent definition Apr 28, 2024
@DanielFran
Copy link
Member

Thanks @timothystone for the contribution

@DanielFran DanielFran merged commit 0db3cbe into jhipster:main Apr 29, 2024
52 checks passed
@timothystone timothystone deleted the fix/spring-profiles-active branch April 29, 2024 21:51
@mraible mraible added this to the 8.4.0 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of Spring Boot Parent may break spring.profiles.active
3 participants