Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to customize home page links #25946

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Conversation

mshima
Copy link
Member

@mshima mshima commented Apr 24, 2024

Related to #23803


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mraible
Copy link
Contributor

mraible commented Apr 25, 2024

This seems like we're making it harder to customize the homepage. Before, you could modify one file, after this change you have to modify two (because people will likely change the "hipster" prefix to match their app).

@mshima
Copy link
Member Author

mshima commented Apr 25, 2024

@mraible why do you think that?
I am changing templates, but generated project are identical.
The focus is blueprints customizations.

@mshima mshima merged commit 3867576 into jhipster:main Apr 25, 2024
52 checks passed
@mshima mshima deleted the customizations branch April 25, 2024 14:23
@mraible
Copy link
Contributor

mraible commented Apr 25, 2024

If the generated projects are identical, I'm fine with this change.

@mraible mraible added this to the 8.4.0 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants