Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] improve create integration test. #25114

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

mshima
Copy link
Member

@mshima mshima commented Feb 6, 2024

Create should fail in some conditions.
Tests relies on findAll last item, but it's not correct for some databases and some primary key types (like string and uuid) since the result is ordered by default.

  • test the rest result and the inserted registry using findById.

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran DanielFran merged commit 9baf937 into jhipster:main Feb 7, 2024
52 checks passed
@mshima mshima deleted the creation-assertion branch February 7, 2024 10:23
@deepu105 deepu105 added this to the 8.2.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants