-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable and Fix keycloak User Registration Config along with defaulting to 'User' group for newly registered users #24765
Conversation
This PR belongs to the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Should we document this as a breaking change, such that existing applications can disable user registration as they might rely on the old default configuration?
Would it go under - https://github.com/jhipster/jhipster.github.io/blob/main/pages/security.md#keycloak or in the release notes? Or I can disable the user registration to false by default. But we might still require a note to inform users that User Registration is now fixed and can be enabled. |
I would say lets keep it enabled as one can register without keycloak too by default. |
@atomfrede Is there anything else I should work upon to get this merged? |
There are two "users" configuration keys in the json. |
@idNoRD I don't see two |
@RawSanj I QA'd this PR today and I can confirm it enables registration by default and puts users in the proper group. However, if I create a brand new app with JHipster 8.3.0 (using Can you please provide the steps needed to reproduce the issue where Keycloak throws an error when enabling user registration? |
@mraible Looks like the registration issue is fixed in another PR-25679 merged (30 March) after this PR was raised (6 Jan). This PR now only enables the User Registrations by default and Puts newly registered users into User Group/Role. |
@RawSanj If I create a new app with I thought this implies the new user is added to the correct group, but the new user has no groups. Please sync this PR with |
Enable and Fix Keycloak User Registration Config along with defaulting to the 'User' group for newly registered users:
User
group to get theUSER Role
.Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.