disable junit test for cyclic required relationships

generators/server/generator.js

@@ -618,6 +618,26 @@ export default class JHipsterServerGenerator extends BaseApplicationGenerator {
     return this.asConfiguringEachEntityTaskGroup(this.delegateTasksToBlueprint(() => this.configuringEachEntity));
   }
 
+  get postPreparingEachEntity() {
+    return this.asPostPreparingEachEntityTaskGroup({
+      checkForCircularRelationships({ entity }) {
+        const detectCyclicRequiredRelationship = (entity, relatedEntities) => {
+          if (relatedEntities.has(entity)) return true;
+          relatedEntities.add(entity);
+          return entity.relationships
+            ?.filter(rel => rel.relationshipRequired || rel.id)
+            .some(rel => detectCyclicRequiredRelationship(rel.otherEntity, new Set([...relatedEntities])));
+        };
+        entity.hasCyclicRequiredRelationship = detectCyclicRequiredRelationship(entity, new Set());
+        entity.skipJunitTests = entity.hasCyclicRequiredRelationship ? 'Cyclic required relationships detected' : undefined;
+      },
+    });
+  }
+
+  get [BaseApplicationGenerator.POST_PREPARING_EACH_ENTITY]() {
+    return this.asPostPreparingEachEntityTaskGroup(this.delegateTasksToBlueprint(() => this.postPreparingEachEntity));
+  }
+
   /** @inheritdoc */
   get default() {
     return this.asDefaultTaskGroup({

generators/server/templates/src/test/java/_package_/_entityPackage_/web/rest/_entityClass_ResourceIT.java.ejs

@@ -19,7 +19,7 @@
 package <%= entityAbsolutePackage %>.web.rest;
 
 <%_
-var filterTestableRelationships = reactive ? reactiveEagerRelations : relationships;
+var filterTestableRelationships = (reactive ? reactiveEagerRelations : relationships).filter(rel => rel.persistableRelationship && !rel.otherEntity.hasCyclicRequiredRelationship);
 const fieldsToTest = fields.filter(field => !field.id && !field.autoGenerate && !field.transient);
 let mapsIdEntity;
 let mapsIdEntityInstance;
@@ -115,6 +115,9 @@ import java.util.concurrent.TimeUnit;
 import org.junit.jupiter.api.AfterEach;
 <%_ } _%>
 import org.junit.jupiter.api.BeforeEach;
+<%_ if (skipJunitTests) { _%>
+import org.junit.jupiter.api.Disabled;
+<%_ } _%>
 import org.junit.jupiter.api.Test;
 <%_ if (implementsEagerLoadApis || databaseTypeNeo4j) { _%>
 import org.mockito.Mock;
@@ -246,6 +249,9 @@ import <%= entityAbsolutePackage %>.domain.enumeration.<%= field.fieldType %>;
  * Integration tests for the {@link <%= entityClass %>Resource} REST controller.
  */
 @IntegrationTest
+<%_ if (skipJunitTests) { _%>
+@Disabled("<%- skipJunitTests %>")
+<%_ } _%>
 <%_ if (implementsEagerLoadApis) { _%>
 @ExtendWith(MockitoExtension.class)
 <%_ } _%>
@@ -525,14 +531,14 @@ filterTestableRelationships.forEach((relationship) => { _%>
   <%_ } _%>
   <%_
   const alreadyGeneratedEntities = [];
-  for (relationship of relationships) {
+  for (relationship of persistableRelationships) {
     const relationshipValidate = relationship.relationshipValidate;
     const otherEntityName = relationship.otherEntityName;
     const otherEntityNameCapitalized = relationship.otherEntityNameCapitalized;
     const relationshipNameCapitalizedPlural = relationship.relationshipNameCapitalizedPlural;
     const relationshipNameCapitalized = relationship.relationshipNameCapitalized;
     const mapsIdUse = relationship.id;
-    if ((relationshipValidate !== null && relationshipValidate) || mapsIdUse) { _%>
+    if ((relationshipValidate !== null && relationshipValidate && !relationship.otherEntity.hasCyclicRequiredRelationship) || mapsIdUse) { _%>
         // Add required entity
       <%_ if (alreadyGeneratedEntities.indexOf(otherEntityName) == -1) { _%>
         <%_ if (relationship.otherEntityUser) { /* TODO or other entity has no unique fields */ _%>

test-integration/samples/jdl-entities/cyclic.jdl

@@ -0,0 +1,13 @@
+@ChangelogDate(20200905000100)
+entity CyclicA {
+  name String
+}
+
+@ChangelogDate(20200905000200)
+entity CyclicB {
+  name String
+}
+
+relationship ManyToMany {
+  CyclicA{b required} to CyclicB{a required}
+}