-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gradle gatling convention plugin #24584
Merged
mshima
merged 10 commits into
jhipster:main
from
atomfrede:19615-gradle-gatling-convention-plugin
Dec 18, 2023
Merged
gradle gatling convention plugin #24584
mshima
merged 10 commits into
jhipster:main
from
atomfrede:19615-gradle-gatling-convention-plugin
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshima
reviewed
Dec 16, 2023
updates jhipster#19615
updates jhipster#19615
atomfrede
force-pushed
the
19615-gradle-gatling-convention-plugin
branch
from
December 16, 2023 16:35
92bcd66
to
6398d21
Compare
atomfrede
force-pushed
the
19615-gradle-gatling-convention-plugin
branch
from
December 16, 2023 20:12
fb9e19f
to
d53d727
Compare
DanielFran
approved these changes
Dec 16, 2023
mshima
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first and initial part to use gradle convention plugins and mostly replace the current apply from approach.
The gatling generator now creates a convention plugin in
buildSrc
and applied it to mainbuild.gradle
. Dependencies and configurations are encapsulated in the convention plugin.Open points I would like to fix are mostly (snapshot) tests
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.