-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not prompt for feign clients when creating a monolith #24566
Conversation
…Client if the application type is not a MONOLITH.
…l prompt for a Feign Client if the application type is not a MONOLITH.
Bounty claimed @ https://opencollective.com/generator-jhipster/expenses/177579 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. Thanks @nil-malh and congrats to your first contribution.
Thanks @nil-malh: bug bounty approved. |
It'd be awesome to have a new release with this fix in it! I'm going to start updating my JHipster Mini-Book, and a screenshot without this question would be nice. |
Added a when to the feingClient command where it checks if the application type is not a Monolith
closes #24560
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.