Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not prompt for feign clients when creating a monolith #24566

Merged
merged 5 commits into from
Dec 15, 2023

Conversation

nil-malh
Copy link
Contributor

@nil-malh nil-malh commented Dec 14, 2023

Added a when to the feingClient command where it checks if the application type is not a Monolith

closes #24560


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

…Client if the application type is not a MONOLITH.
…l prompt for a Feign Client if the application type is not a MONOLITH.
@CLAassistant
Copy link

CLAassistant commented Dec 14, 2023

CLA assistant check
All committers have signed the CLA.

@nil-malh
Copy link
Contributor Author

@atomfrede atomfrede changed the title Fix #24560 Do not prompt for feign clients when creating a monolith Fix #24560 Dec 15, 2023
@atomfrede atomfrede changed the title Do not prompt for feign clients when creating a monolith Fix #24560 Do not prompt for feign clients when creating a monolith Dec 15, 2023
Copy link
Member

@atomfrede atomfrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Thanks @nil-malh and congrats to your first contribution.

@DanielFran DanielFran merged commit 68e4052 into jhipster:main Dec 15, 2023
51 checks passed
@DanielFran
Copy link
Member

Thanks @nil-malh: bug bounty approved.

@mraible
Copy link
Contributor

mraible commented Jan 7, 2024

It'd be awesome to have a new release with this fix in it! I'm going to start updating my JHipster Mini-Book, and a screenshot without this question would be nice.

@deepu105 deepu105 added this to the 8.2.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jhipster v8.1.0 asks to generate Feign client during Monolithic app creation
6 participants