Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gradle] generate initial files for convention plugin usage #24551

Merged

Conversation

atomfrede
Copy link
Member

This PR adds the needed "infrastructure" part to use gradle convention plugins.

updates #19615


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@atomfrede atomfrede force-pushed the 19615-inital-gradle-convention-plugin-infra branch 2 times, most recently from 8e02b20 to 49675aa Compare December 12, 2023 22:59
@atomfrede atomfrede force-pushed the 19615-inital-gradle-convention-plugin-infra branch from 49675aa to 71debad Compare December 12, 2023 23:14
@atomfrede atomfrede force-pushed the 19615-inital-gradle-convention-plugin-infra branch from 1dff82b to 3b115cf Compare December 13, 2023 06:57
@atomfrede
Copy link
Member Author

Strange behaviour with checkstyle/nohttp and dependency resolution, which I didn't had when trying it out. It worked yesterday, so maybe some issue with upstream things. Will have a look later.

@atomfrede
Copy link
Member Author

The dependency resolution issue is tracked at checkstyle here: checkstyle/checkstyle#14123 for now i have applied the workaround described here

@atomfrede atomfrede requested a review from mshima December 14, 2023 14:28
@mshima
Copy link
Member

mshima commented Dec 14, 2023

From your sample, gradle plugins uses the format id 'plugin'.
At current implementation you are adding a dependency instead of a plugin.
Is this the desired behavior?

@atomfrede
Copy link
Member Author

@mshima This is just the "infrastructure" inside buildSrc folder. So adding a dependency is correct. These are needed dependencies for the convention plugins. One need to add third party plugins to the dependencies block inside buildSrc/build.gradle to use them within the convention plugins. See https://github.com/atomfrede/jhipster-gradle-improvements/blob/main/buildSrc/build.gradle

Applying and creating convention plugins will be separate PRs.

@mshima mshima merged commit 29e9e8a into jhipster:main Dec 14, 2023
51 checks passed
@deepu105 deepu105 added this to the 8.2.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants