Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make banners similar between frameworks #24050

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Make banners similar between frameworks #24050

merged 2 commits into from
Oct 30, 2023

Conversation

mraible
Copy link
Contributor

@mraible mraible commented Oct 30, 2023

I created apps using the following commands:

jhipster --defaults --skip-install --client-framework angular
jhipster --defaults --skip-install --client-framework react
jhipster --defaults --skip-install --client-framework vue

Here are the results:

Screenshot 2023-10-30 at 11 44 17 AM Screenshot 2023-10-30 at 11 53 44 AM Screenshot 2023-10-30 at 11 56 04 AM

This PR makes the banners more similar. You might notice there are still some differences. Notably, Angular has no line around the body content, React has a line with a silver background, and Vue has no line but does have a gray background.

angular react vue

Please make sure the below checklist is followed for Pull Requests.

@DanielFran
Copy link
Member

@mraible I noticed it is missing the v in the version for react

@mraible
Copy link
Contributor Author

mraible commented Oct 30, 2023

Good eye, @DanielFran! Fixed in fd5d3f3.

@mraible mraible merged commit e68a3a4 into main Oct 30, 2023
47 checks passed
@mraible mraible deleted the banner-css branch October 30, 2023 23:15
@deepu105 deepu105 added this to the 8.0.0 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants