Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize caching restore #24049

Merged
merged 1 commit into from
Oct 30, 2023
Merged

optimize caching restore #24049

merged 1 commit into from
Oct 30, 2023

Conversation

mshima
Copy link
Member

@mshima mshima commented Oct 30, 2023

Or matrix is quite big, a save/restore cache action is not really useful.
We use different frameworks angular/react/vue and optional dependencies to be cached, we would require a 1-to-1 cache/sample but cache limit is not big enough (~40 samples).
Our build-cache brings a very wide cache support, use it everywhere.

Switch every action/cache usage to be restore only except the build-cache.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran
Copy link
Member

@mshima Same changes are required in BOM project?

@mshima
Copy link
Member Author

mshima commented Oct 30, 2023

@mshima Same changes are required in BOM project?

I want to extract build-cache and cache restore to a local action to be reused.
We can keep as it is for now.
Main cache is much more important given the number os PRs.

@DanielFran DanielFran merged commit b2da792 into jhipster:main Oct 30, 2023
47 checks passed
@github-actions github-actions bot deleted the skip_ci-cache branch October 30, 2023 22:20
@deepu105 deepu105 added this to the 8.0.0 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants