Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Hyphen issue the base application name #23932

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

dmateen
Copy link
Contributor

@dmateen dmateen commented Oct 20, 2023

Fixed Hyphen issue the base application name


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2023

CLA assistant check
All committers have signed the CLA.

@mraible mraible requested a review from mshima October 26, 2023 04:36
@mraible
Copy link
Contributor

mraible commented Oct 30, 2023

I tried creating an app with a dash in it and I'm unable to run Cypress tests:

  login modal
    ✓ greets with signin (371ms)
    ✓ requires username (592ms)
    ✓ requires password (484ms)
Session with given id not found.
Error: Session with given id not found.
    at <embedded>:2466:519827
    at _._handleMessage (<embedded>:2466:521860)
    at A.<anonymous> (<embedded>:2466:521673)
    at A.emit (node:events:513:28)
    at g.U (<embedded>:2466:506953)
    at g.emit (node:events:513:28)
    at g.dataMessage (<embedded>:2466:487328)
    at <embedded>:2466:486860
    at <embedded>:2466:478182
    at <embedded>:2466:479134
    at afterWrite (node:internal/streams/writable:500:5)
    at onwrite (node:internal/streams/writable:480:7)
    at Zlib.cb (node:internal/streams/transform:190:7)
    at Zlib.processCallback (node:zlib:613:8)

JHipster version:

[email protected] /Users/mraible/Desktop/dash
└── [email protected]
JHipster configuration, a .yo-rc.json file generated in the root folder
.yo-rc.json file
{
  "generator-jhipster": {
    "applicationType": "monolith",
    "authenticationType": "jwt",
    "baseName": "foo-bar",
    "buildTool": "maven",
    "cacheProvider": "ehcache",
    "clientFramework": "vue",
    "clientTestFrameworks": [
      "cypress"
    ],
    "clientTheme": "none",
    "creationTimestamp": 1698631309268,
    "cypressAudit": true,
    "cypressCoverage": null,
    "databaseType": "sql",
    "devDatabaseType": "postgresql",
    "devServerPort": 9060,
    "enableGradleEnterprise": null,
    "enableHibernateCache": true,
    "enableSwaggerCodegen": false,
    "enableTranslation": true,
    "entities": [],
    "gradleEnterpriseHost": null,
    "jhipsterVersion": "8.0.0-rc.1",
    "languages": [
      "en",
      "fr",
      "hy"
    ],
    "messageBroker": false,
    "microfrontend": null,
    "microfrontends": [],
    "nativeLanguage": "en",
    "packageName": "com.mycompany.myapp",
    "prodDatabaseType": "postgresql",
    "reactive": false,
    "searchEngine": false,
    "serverPort": null,
    "serverSideOptions": [],
    "serviceDiscoveryType": false,
    "testFrameworks": [
      "cypress"
    ],
    "websocket": false,
    "withAdminUi": true
  }
}
Environment and Tools

openjdk version "21" 2023-09-19
OpenJDK Runtime Environment GraalVM CE 21+35.1 (build 21+35-jvmci-23.1-b15)
OpenJDK 64-Bit Server VM GraalVM CE 21+35.1 (build 21+35-jvmci-23.1-b15, mixed mode, sharing)

git version 2.39.3 (Apple Git-145)

node: v20.9.0
npm: 10.1.0

Docker version 24.0.6, build ed223bc

JDL for the Entity configuration(s) entityName.json files generated in the .jhipster directory
JDL entity definitions

@mraible
Copy link
Contributor

mraible commented Oct 30, 2023

It makes it a bit further if I take the dash out of the name and recreate the app.

  Running:  administration/administration.cy.ts                                             (1 of 6)


  /admin
    /user-management
      ✓ should load the page (544ms)
    /metrics
      ✓ should load the page (308ms)
    /health
      ✓ should load the page (313ms)
    /logs
Session with given id not found.
Error: Session with given id not found.
    at <embedded>:2466:519827
    at _._handleMessage (<embedded>:2466:521860)
    at A.<anonymous> (<embedded>:2466:521673)
    at A.emit (node:events:513:28)
    at g.U (<embedded>:2466:506953)
    at g.emit (node:events:513:28)
    at g.dataMessage (<embedded>:2466:487328)
    at <embedded>:2466:486860
    at <embedded>:2466:478182
    at <embedded>:2466:479134
    at afterWrite (node:internal/streams/writable:500:5)
    at onwrite (node:internal/streams/writable:480:7)
    at Zlib.cb (node:internal/streams/transform:190:7)
    at Zlib.processCallback (node:zlib:613:8)

My Node version:

v18.18.2

@mraible
Copy link
Contributor

mraible commented Oct 30, 2023

It works if I use Firefox, so I'll merge.

npx cypress run --e2e --browser firefox --headed

Thanks for your contribution, @dmateen!

@mraible mraible merged commit cfc5951 into jhipster:main Oct 30, 2023
20 checks passed
@deepu105 deepu105 added this to the 8.0.0 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants