Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to hibernate 6.2.x #23107

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

mshima
Copy link
Member

@mshima mshima commented Aug 9, 2023

The initial ideal was to use hibernate.timezone.default_storage: NORMALIZE_UTC configuration, but dev (h2) tests never matches the prod test. prod succeeds while dev fails.
One possibility is that NORMALIZE_UTC will only make difference if db supports native timezone, which h2 supports but postgresql, mysql and mariadb don't.

Tested locally at local timezone:

  • Postgresql/H2 using dev/prod profiles 👍
  • MySql/H2 using dev/prod profiles 👍
  • MariaDB/H2 using dev/prod profiles 👍

I want to do some additional tests using NORMALIZE_UTC, but can be done later.
My initial tests, NORMALIZE_UTC succeed using Postgresql and MySql but fails with H2.
I want to test if data stored at db changes.

Fixes #22874.
Related to #22579.
Closes #23041.

Related to #22946.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran DanielFran merged commit e505d53 into jhipster:main Aug 9, 2023
@github-actions github-actions bot deleted the skip_ci-hibernate_6_2 branch August 9, 2023 08:25
@deepu105 deepu105 added this to the 8.0.0-beta.3 milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants