Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fakerjs 8 deprecated method #22948

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Jul 22, 2023

@qmonmert qmonmert changed the title Fakerjs: deprecated method Fakerjs 8 deprecated method Jul 22, 2023
@DanielFran DanielFran added $100 https://www.jhipster.tech/bug-bounties/ $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ labels Jul 22, 2023
@qmonmert qmonmert force-pushed the fakerjsrandomdeprecated branch from f5d1d93 to 7e60891 Compare July 23, 2023 14:25
@qmonmert qmonmert marked this pull request as ready for review July 23, 2023 15:22
@qmonmert
Copy link
Contributor Author

@mshima do you think that ng-gradle-fr build failed is a false positive?

@mshima
Copy link
Member

mshima commented Jul 24, 2023

@mshima do you think that ng-gradle-fr build failed is a false positive?

Faker seems to generate an incompatible character. Should check if input is correctly handling the sample, if it’s correct, should replace the offending char.

Check this:

+    stringRequiredMika: "ah à l'insu de",

@mshima
Copy link
Member

mshima commented Jul 24, 2023

ng-default still have deprecations:

[@faker-js/faker]: faker.name is deprecated since v8.0 and will be removed in v10.0. Please use faker.person instead.

@qmonmert qmonmert force-pushed the fakerjsrandomdeprecated branch from 7e60891 to 2c2d2da Compare July 24, 2023 11:10
@qmonmert
Copy link
Contributor Author

@mshima I updated faker.person, but how do you see stringRequiredMika: "ah à l'insu de", ?

@mshima
Copy link
Member

mshima commented Jul 24, 2023

At PR generated source diff:
IMG_0417

There is an strange value here:
IMG_0418

@qmonmert
Copy link
Contributor Author

@mshima ah thanks, I've never seen that 🙂
the character ' is apostrophe and examples are valid in french language
when you say Should check if input is correctly handling the sample, if it’s correct, should replace the offending char. what do you mean?

@mshima
Copy link
Member

mshima commented Jul 24, 2023

@mshima ah thanks, I've never seen that 🙂
the character ' is apostrophe and examples are valid in french language
when you say Should check if input is correctly handling the sample, if it’s correct, should replace the offending char. what do you mean?

Cypress or angular implementation is not accepting the generated sample.
Last commit should not convert apostrophe into html escaped char.
I think it will fix the problem.

@qmonmert
Copy link
Contributor Author

@DanielFran https://opencollective.com/generator-jhipster/expenses/151629 🙂
@mshima thanks for the help 🙂

@DanielFran
Copy link
Member

@qmonmert approved

@deepu105 deepu105 added this to the 8.0.0-beta.3 milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: jhipster-internals $100 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants