Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karakalpak lang #20946

Merged
merged 20 commits into from
Jan 31, 2023
Merged

Karakalpak lang #20946

merged 20 commits into from
Jan 31, 2023

Conversation

saylaww
Copy link
Contributor

@saylaww saylaww commented Jan 27, 2023


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

saylaww and others added 18 commits January 13, 2023 16:21
Testing language: kr-Latin-kr
getJavaLocale: kr-Latin-kr
Error:  Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 6.58 s <<< FAILURE! - in tech.jhipster.sample.service.MailServiceIT
Error:  tech.jhipster.sample.service.MailServiceIT.testSendLocalizedEmailForAllSupportedLanguages  Time elapsed: 0.287 s  <<< ERROR!
java.lang.NullPointerException: Cannot invoke "java.net.URL.getFile()" because "resource" is null
	at tech.jhipster.sample.service.MailServiceIT.testSendLocalizedEmailForAllSupportedLanguages(MailServiceIT.java:258)
…_lang

# Conflicts:
#	generators/generator-constants.mjs
#	generators/server/templates/src/test/java/package/service/MailServiceIT.java.ejs
@saylaww
Copy link
Contributor Author

saylaww commented Jan 30, 2023

Are all the bugs over? Now the Karakalpak language has been added to the jhipster generator?

Copy link
Contributor

@mraible mraible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll let someone with more i18n experience merge it.

@DanielFran DanielFran merged commit efa1317 into jhipster:main Jan 31, 2023
@DanielFran
Copy link
Member

Thanks @saylaww for the contribution

@saylaww
Copy link
Contributor Author

saylaww commented Jan 31, 2023

When it's all over, Why isn't the Karakalpak language included in the jhipster generator?

@DanielFran
Copy link
Member

@saylaww it has been merged together main, but we did not release a new version of the generator that will include it

@saylaww
Copy link
Contributor Author

saylaww commented Jan 31, 2023

@saylaww it has been merged together main, but we did not release a new version of the generator that will include it

When will the new generator come out?

@mraible
Copy link
Contributor

mraible commented Jan 31, 2023

You don't need to wait for a release to use it. However, waiting for the release will likely guarantee that everything works. You can use the main branch using the instructions in this video.

https://www.youtube.com/watch?v=0UFWJ3JGZa0

For a shortcut, this Gist has the commands:

https://gist.github.com/mraible/1e9b8b755ad6ea7c3dcd86fc860a6d56

@DanielFran DanielFran mentioned this pull request Feb 16, 2023
1 task
@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants