-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Karakalpak lang #20946
Karakalpak lang #20946
Conversation
Testing language: kr-Latin-kr getJavaLocale: kr-Latin-kr Error: Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 6.58 s <<< FAILURE! - in tech.jhipster.sample.service.MailServiceIT Error: tech.jhipster.sample.service.MailServiceIT.testSendLocalizedEmailForAllSupportedLanguages Time elapsed: 0.287 s <<< ERROR! java.lang.NullPointerException: Cannot invoke "java.net.URL.getFile()" because "resource" is null at tech.jhipster.sample.service.MailServiceIT.testSendLocalizedEmailForAllSupportedLanguages(MailServiceIT.java:258)
…_lang # Conflicts: # generators/generator-constants.mjs # generators/server/templates/src/test/java/package/service/MailServiceIT.java.ejs
generators/server/templates/src/test/java/package/service/MailServiceIT.java.ejs
Outdated
Show resolved
Hide resolved
generators/server/templates/src/test/java/package/service/MailServiceIT.java.ejs
Outdated
Show resolved
Hide resolved
Are all the bugs over? Now the Karakalpak language has been added to the jhipster generator? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll let someone with more i18n experience merge it.
Thanks @saylaww for the contribution |
When it's all over, Why isn't the Karakalpak language included in the jhipster generator? |
@saylaww it has been merged together main, but we did not release a new version of the generator that will include it |
When will the new generator come out? |
You don't need to wait for a release to use it. However, waiting for the release will likely guarantee that everything works. You can use the https://www.youtube.com/watch?v=0UFWJ3JGZa0 For a shortcut, this Gist has the commands: https://gist.github.com/mraible/1e9b8b755ad6ea7c3dcd86fc860a6d56 |
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.