Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use GITHUB_OUTPUT to expose outputs #20930

Merged
merged 2 commits into from
Feb 6, 2023
Merged

ci: use GITHUB_OUTPUT to expose outputs #20930

merged 2 commits into from
Feb 6, 2023

Conversation

rlespinasse
Copy link
Contributor

@rlespinasse rlespinasse commented Jan 26, 2023

GitHub Actions have depreciated the set-output command to avoid vulnerabilities

See changelog https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Comment on lines 135 to 137
echo 'matrix<<EOF' >> $GITHUB_OUTPUT
cat matrix.json >> $GITHUB_OUTPUT
echo 'EOF' >> $GITHUB_OUTPUT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note sure why this part is not working
@mshima any clue?

Copy link
Member

@mshima mshima Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matrix.json file doesn't contain a trailing EOL.

@mshima mshima merged commit d10bc1d into jhipster:main Feb 6, 2023
@mshima
Copy link
Member

mshima commented Feb 6, 2023

Thanks @rlespinasse

@rlespinasse rlespinasse deleted the github-output branch February 6, 2023 18:07
@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants