fix add and drop fk relationships with involved primary key columns not named 'id'

[OmarHawk]

Fix #20536

---

Please make sure the below checklist is followed for Pull Requests.

• All continuous integration tests are green
• Tests are added where necessary
• The JDL part is updated if necessary
• jhipster-online is updated if necessary
• Documentation is added/updated where necessary
• Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

[OmarHawk]

I'll continue working on this. ;-)

[mshima]

• Maybe a snapshot test for relationship removal (just a snapshot is enough IMO):
  

  generator-jhipster/generators/liquibase-changelogs/incremental-liquibase.spec.mts

  Line 592 in 5f645ea

  context('when adding a relationship', () => {

• And an actual relationship removal at https://github.com/jhipster/generator-jhipster/tree/main/test-integration/incremental-changelog-samples.

[OmarHawk]

• Maybe a snapshot test for relationship removal (just a snapshot is enough IMO):
  

  generator-jhipster/generators/liquibase-changelogs/incremental-liquibase.spec.mts

  Line 592 in 5f645ea

  context('when adding a relationship', () => {

I'll add one

• And an actual relationship removal at https://github.com/jhipster/generator-jhipster/tree/main/test-integration/incremental-changelog-samples.

I added @Id fields where there is already a relationship removal in the existing test case. It is named 'rename field' but relationship removal is also already in there... Maybe, we should rename that test. ;-)

[OmarHawk]

• Maybe a snapshot test for relationship removal (just a snapshot is enough IMO):
  

  generator-jhipster/generators/liquibase-changelogs/incremental-liquibase.spec.mts

  Line 592 in 5f645ea

  context('when adding a relationship', () => {

I'll add one

Done.

[mshima]

@OmarHawk can you test this change?

[mshima]

Thanks @OmarHawk

[OmarHawk]

Bug bounty claim https://opencollective.com/generator-jhipster/expenses/120027 :-)

[DanielFran]

@OmarHawk Approved