Rework cypress settings page. #20316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshima
force-pushed
the
skip_ci-cypress_register
branch
from
1e8e885 to
564a1d0
Compare
6 tasks
mraible
reviewed
Nov 15, 2022
| originalUserAccount = account; | ||
| testUserAccount = { ...account, email: testUserEmail }; | ||
|
|
||
| // need to modify email because default email does not match regex in some frameworks |
There was a problem hiding this comment.
Why can't we just fix the regex in some frameworks?
There was a problem hiding this comment.
localhost is not a valid domain for emails.
Not sure which approach to use.
There was a problem hiding this comment.
We could use example.com, since that's what it's designed for. https://example.com/
Or, any of the jhipster domains. For example, I own jhipster.org and just redirect it to jhipster.tech.
There was a problem hiding this comment.
Looks good to use example.com.
I will create an issue about this.
mraible
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.