-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Zalando to Spring Framework 6 problem support implementation #19991[skip-ci] #20080
Migrate from Zalando to Spring Framework 6 problem support implementation #19991[skip-ci] #20080
Conversation
@mraible this migration is complete except the exception cause part, out of the box Spring's Problem implementation doesn't seem to support this (at least I couldn't find any documentation) like zalando. I can try something similar to zalando by extending the base ProblemDetail class but have to look at how Spring handles the extended class during json conversion (with nesting)... |
You might try creating an extended problem detail class and adding |
Yeah sure. thanks |
generators/server/templates/src/main/java/package/config/WebConfigurer.java.ejs
Show resolved
Hide resolved
The CI failures don't seem to be related to this PR. I'm not sure what's causing them.
|
I have fixed SecurityConfiguration related to mvcMatcher along with 3 other test failures, hopefully that will fix this. Will be pushing the changes in a bit |
1. add GET method for authenticate endpoint in SecurityConfiguration for JWT type 2. add rememberMe defaults to test property 3. add mvcHandlerMappingIntrospector bean for MockMvcResultMatchers support 4. MicroMeter fix for malformed jwt token
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
$500 bug bounty claim https://opencollective.com/generator-jhipster/expenses/160399 |
fixes #19991
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.