Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix generate-blueprint workflow. #19594

Merged
merged 3 commits into from
Sep 2, 2022

Conversation

mshima
Copy link
Member

@mshima mshima commented Aug 30, 2022

  • add another priority called postInstall.
    npm install happens later at install priority, git commit happens earlier at end priority.
    Leaving no option for a task to execute between them, so a postInstall will allow to execute a npm dependency and commit the generated file to git.
  • force to update the generated blueprint snapshot to catch blueprint test errors.
  • fix outdated jest api.

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima force-pushed the skip_ci-generate_blueprint branch from c611a8a to cf7e19b Compare August 30, 2022 14:10
@mraible
Copy link
Contributor

mraible commented Sep 1, 2022

@mshima Should this be a part of the next v7 release?

@mshima
Copy link
Member Author

mshima commented Sep 1, 2022

@mraible generated blueprint tests are broken, not compatible with jest 28.

@mshima
Copy link
Member Author

mshima commented Sep 1, 2022

So yes.

@mraible mraible added this to the 7.9.3 milestone Sep 1, 2022
@mshima mshima marked this pull request as ready for review September 1, 2022 16:18
@pascalgrimaud pascalgrimaud merged commit fbe67d4 into jhipster:main Sep 2, 2022
@mshima mshima deleted the skip_ci-generate_blueprint branch September 2, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants