Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elasticsearch test configuration and others fixes/improvements #19409

Merged
merged 5 commits into from
Aug 15, 2022

Conversation

mshima
Copy link
Member

@mshima mshima commented Aug 15, 2022

  • configure non reactive elastic search to use RefreshPolicy.IMMEDIATE, reactive already uses it.
  • move elasticsearch cleanup to a dedicated AfterEach block and verify the cleanup
  • add xpack.security.enabled=false setting to elasticsearch testcontainer which is already set at docker compose file (stops generating tons of warnings)
  • when implementing Persistable interface, new field should be ignored by Jackson.
  • add log safe marker to an initialization log.
  • add docker-compose npm script for Microservices+workspaces.

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran DanielFran merged commit d8981f5 into jhipster:main Aug 15, 2022
@mshima mshima deleted the skip_ci-elasticsearch branch August 15, 2022 21:04
@DanielFran DanielFran added this to the 7.9.3 milestone Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants