Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angular] improve filter component/model #19372

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

mshima
Copy link
Member

@mshima mshima commented Aug 8, 2022

  • add support to multiples values for each filter
  • decouple filter changes from the filter component. (subscribe changes at the filter model, instead of at the component)
    make easier to use a custom component
  • cleanup exported interfaces

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima
Copy link
Member Author

mshima commented Aug 8, 2022

CC @OmarHawk

@OmarHawk
Copy link
Contributor

OmarHawk commented Aug 8, 2022

Nice!

@mshima mshima marked this pull request as draft August 9, 2022 02:40
@mshima mshima marked this pull request as ready for review August 9, 2022 18:07
@mshima mshima marked this pull request as draft August 10, 2022 13:35
@mshima mshima force-pushed the skip_ci-angular_filtering branch 3 times, most recently from f989691 to 518f3d8 Compare August 16, 2022 11:56
@mshima mshima changed the title [angular] add support to multiples values for each filter [angular] improve filter component/model Aug 16, 2022
@mshima mshima force-pushed the skip_ci-angular_filtering branch from 518f3d8 to e0415ad Compare August 16, 2022 12:12
@mshima mshima marked this pull request as ready for review August 16, 2022 13:54
@mraible mraible merged commit 71d81b8 into jhipster:main Aug 17, 2022
@mshima mshima deleted the skip_ci-angular_filtering branch August 17, 2022 11:35
@DanielFran DanielFran added this to the 7.9.3 milestone Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants