-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix spring security warning #19184
fix spring security warning #19184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still in draft for the reactive part I guess?
It was late yesterday, couldn’t check the build result. |
I didn't check but at least it seems to be(?). I am not sure what my comment about the csp was, need to check my sample again. #18534 |
I didn’t saw that bug report. 😕 |
Awesome. I also remember h2 and swagger only. Everything else should also be found our integration/e2e tests. |
Indeed h2-console and swagger-ui breaks with this PR. Line 213 in 91358fc
to sameOrigin() seems to fix them.
Microservice:
Microfrontend:
|
Fix
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.