Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable sonar at ci if frontend or backend were skiped. #18937

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

mshima
Copy link
Member

@mshima mshima commented Jun 16, 2022

The build fails otherwise with the missing results.
Example: https://github.com/jhipster/generator-jhipster/runs/6917256799?check_suite_focus=true


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran
Copy link
Member

Not sure why it fails, probably still nething related with configuration...
Let's merge it!
Anyway we need to see why coverage dropped half...

@DanielFran DanielFran merged commit 6443e85 into jhipster:main Jun 17, 2022
@mshima mshima deleted the skip_ci-sonar branch June 17, 2022 10:41
@DanielFran DanielFran added this to the 7.9.0 milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants