Update React Router to 6.3.0 #18722
Merged
Update React Router to 6.3.0 #18722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
theme: dependencies
DanielFran
reviewed
May 23, 2022
emilpaw
force-pushed
the
update-react-router-to-6-3-0
branch
from
bd83a75 to
03bbfdc
Compare
emilpaw
force-pushed
the
update-react-router-to-6-3-0
branch
from
03bbfdc to
fbcdc0b
Compare
emilpaw
force-pushed
the
update-react-router-to-6-3-0
branch
4 times, most recently
from
0f18c9c to
1670e5b
Compare
emilpaw
force-pushed
the
update-react-router-to-6-3-0
branch
2 times, most recently
from
7986774 to
8132e77
Compare
A step towards upgrading react router to 6.3.0. This changes make the generated code work only when the user management is skipped and no entities are generated.
It's not needed anymore because React Router 6.3.0 has types included.
A pattern like this does not work with React Router 6.3.0
emilpaw
force-pushed
the
update-react-router-to-6-3-0
branch
from
8132e77 to
f2cfef0
Compare
emilpaw
force-pushed
the
update-react-router-to-6-3-0
branch
from
f2cfef0 to
38ad4b7
Compare
When OIDC is used the redirect path is different. With this change the correct path is checked when using OIDC.
emilpaw
force-pushed
the
update-react-router-to-6-3-0
branch
from
060af6f to
bfb7020
Compare
DanielFran
previously requested changes
Jun 7, 2022
|
@qmonmert I am not a react expert. Can you help and validate the PR? |
mshima
reviewed
Jun 7, 2022
qmonmert
reviewed
Jun 7, 2022
...main/webapp/app/modules/administration/user-management/user-management-delete-dialog.tsx.ejs
Outdated
Show resolved
Hide resolved
qmonmert
previously approved these changes
Jun 7, 2022
|
Bug bounty claimed: https://opencollective.com/generator-jhipster/expenses/115034 Thanks :) |
|
@emilpaw approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #18571
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.