Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cypress downloads and videos folders. #18553

Merged
merged 2 commits into from
May 11, 2022
Merged

Conversation

mshima
Copy link
Member

@mshima mshima commented May 2, 2022

Fixes #18536.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima changed the title Set cypress downloads and viedos folders. Set cypress downloads and videos folders. May 2, 2022
@mshima mshima force-pushed the skip_ci-cypress branch from a1f8b27 to d228945 Compare May 2, 2022 12:58
@mshima mshima marked this pull request as ready for review May 10, 2022 16:40
@mshima mshima requested a review from mraible May 10, 2022 18:59
@mraible
Copy link
Contributor

mraible commented May 10, 2022

It's OK to specify these folders. However, I'm more interested in ignoring them. Downloads, screenshots, and videos don't seem like something you'd want in source control.

@mshima
Copy link
Member Author

mshima commented May 10, 2022

BUILD_DIR is target for maven and build for gradle.
They are ignored by git.
We already put node, webpack cache, cypress screenshots and others temporary directories there.

@mshima mshima merged commit e4de8eb into jhipster:main May 11, 2022
@mshima mshima deleted the skip_ci-cypress branch May 11, 2022 11:57
@DanielFran DanielFran added this to the 7.9.0 milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress prompts you to Continue Download or Quit every so often
3 participants