Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use randomAlphanumeric instead of random for password in tests codes #18530

Merged
merged 5 commits into from
May 4, 2022

Conversation

pmverma
Copy link
Member

@pmverma pmverma commented Apr 30, 2022

Follow up of #18502

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@pmverma
Copy link
Member Author

pmverma commented Apr 30, 2022

It is strange that I am not able to reproduce the failing build locally.

@DanielFran , Can you please help follow the steps to reproduce?

  1. Run mkdir pr18530 && cd pr18530 && touch .yo-rc.json
  2. Copy .yo-rc.json of failing build
  3. Remove entities from .yo-rc.json
  4. Run jhipster
  5. Run ./mvnw clean verify

Failing error log is strange.
I need to check for the string literal "test", it is defined nowhere in the file.

@DanielFran
Copy link
Member

@pmverma I did the test this morning and was not able to reproduce it locally also :(

Maybe something related with ci-cd cache?
@mshima any clue?

@mshima
Copy link
Member

mshima commented May 4, 2022

My guess would be that the cleanup failed.
I added a change to test.

@mshima
Copy link
Member

mshima commented May 4, 2022

It is a leftover from UserJWTControllerIT test.
Don't know why it started failing with this PR.

@mshima mshima merged commit 9b506ae into jhipster:main May 4, 2022
@DanielFran DanielFran added this to the 7.9.0 milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants