-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
throw when different client frameworks are used for microfrontends #18470
throw when different client frameworks are used for microfrontends #18470
Conversation
1978110
to
f94ef12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be simplified.
a247b41
to
4c8b7c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cli/import-jdl.js
Outdated
@@ -431,7 +431,7 @@ class JDLProcessor { | |||
applicationWithEntities.config.baseName !== baseName && | |||
applicationWithEntities.entities.find(entity => entity.microserviceName === baseName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
const microfrontends = applicationWithEntities.config.microfrontends || [];
applicationWithEntities.entities.find(entity => entity.microserviceName === baseName) | |
( | |
applicationWithEntities.entities.find(entity => entity.microserviceName === baseName) || | |
microfrontends.includes(baseName) | |
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Done.
4c8b7c3
to
f4fba20
Compare
Bug bounty claimed: https://opencollective.com/generator-jhipster/expenses/115032 Thanks :) |
@emilpaw approved |
Fix #18200
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.