-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add relationships and reactive support to custom entity packages. #16592
Conversation
c0b4666
to
85f963d
Compare
@mraible should fix your jdl #16041 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm this fixes the problem, everything compiles, and e2e tests pass. As I was running these tests, I noticed that all the entity classes are generated at the root level and I thought to myself, "wouldn't it be cool if I could put all generated entity-related classes in their own sub-package?"
I tried @EntityPackage(app.blog)
and @EntityPackage(app/blog)
and neither of them work. Just wanted to make a note of this since others might think of this too.
@mraible should work now using |
Double quotes works splendidly! 🎉 It looks like single quotes aren't supported:
Here's the JDL I used to test:
|
Merging because this is a really cool feature. |
Followup to #16041.
Having JDLs instead of .yo-rc.json and .jhipster/* entities is cleaner and easier to maintain.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.