Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not save Okta password in .yo-rc.json anymore #16585

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

yuvarajsanjeevi
Copy link
Contributor

Fix #16394

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran DanielFran changed the title Fix#16394 Okta password is written to .yo-rc.json even when Okta is used Oct 6, 2021
@DanielFran DanielFran changed the title Okta password is written to .yo-rc.json even when Okta is used Do not save Okta password in .yo-rc.json anymore Oct 6, 2021
@DanielFran DanielFran requested a review from mraible October 6, 2021 10:50
Copy link
Contributor

@mraible mraible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried again with a fresh new project and ran jhipster jdl blog-oauth2, then deployed to Heroku. It works as desired!

@mraible mraible merged commit 18cac34 into jhipster:main Oct 6, 2021
@pascalgrimaud pascalgrimaud added this to the 7.3.0 milestone Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Okta password is written to .yo-rc.json even when Okta is not used
3 participants