Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react development server and add GitHub action for dynamic workflows. #16150

Merged
merged 3 commits into from
Sep 5, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented Sep 3, 2021

  • Fixes react development server
  • Add build-matrix action to allow dynamic workflows for modularized tests
  • Add trailing -- to composite npm scripts.
    • Allows scripts to call others scripts passing escaped parameters (-- --arg) correctly.
      Without needing double escaping -- -- --arg
  • Add Dev Server workflow for testing webpack-devserver, browser sync and dev profile.

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@Tcharl
Copy link
Contributor

Tcharl commented Sep 4, 2021

Reviewed, looks OK

@mshima mshima changed the title Fixes react development server and add GitHub action for dynamic workflows. Fix react development server and add GitHub action for dynamic workflows. Sep 4, 2021
@mshima
Copy link
Member Author

mshima commented Sep 5, 2021

Approved merging.

@mshima mshima merged commit 3c6f3c7 into jhipster:main Sep 5, 2021
@mshima mshima deleted the skip_ci-dev_server branch September 5, 2021 00:45
@deepu105 deepu105 added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $100 https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ and removed $100 https://www.jhipster.tech/bug-bounties/ labels Sep 5, 2021
@deepu105
Copy link
Member

deepu105 commented Sep 5, 2021

@mshima I have assigned a bounty for this, please claim the same

@pascalgrimaud pascalgrimaud added this to the 7.2.0 milestone Sep 11, 2021
@mshima
Copy link
Member Author

mshima commented Oct 5, 2021

@pascalgrimaud
Copy link
Member

@mshima : approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants