Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit use of "SET IDENTITY_INSERT jhi_user ON/OFF" for mssql #15492

Merged
merged 11 commits into from
Jul 26, 2021

Conversation

DanielFran
Copy link
Member

@DanielFran DanielFran commented Jun 28, 2021

Related with #15264 and liquibase update to 4.4.0+

See:
liquibase/liquibase-mssql#41
liquibase/liquibase-mssql@0c2b40c

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@atomfrede
Copy link
Member

This still requires the update to 4.4.0 is that correct?

const LIQUIBASE_VERSION = '4.3.5';

@DanielFran
Copy link
Member Author

@atomfrede Yes, forget to include the dependency update in the generator... :P

@DanielFran DanielFran merged commit fc5d582 into jhipster:main Jul 26, 2021
@pascalgrimaud pascalgrimaud added this to the 7.2.0 milestone Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants