Remove non-conforming & ignored link type #11817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidohallik
approved these changes
May 19, 2020
kaidohallik
added a commit
to kaidohallik/generator-jhipster
that referenced
this pull request
Feb 7, 2021
Removes also unused *.css from Vue. And Vue 404.html is not using redundant shortcut in link any more as Angular and React are not using. For index.html this PR: * applies the following fixes also for Vue: jhipster#8124, jhipster#10106, jhipster#11817 * uses buildTool variable instead of hardcoded mvnw * removes redundant div with classes lds-css (not existing) and ng-scope (old AngularJS relict) also from Angular and React
kaidohallik
added a commit
to kaidohallik/generator-jhipster
that referenced
this pull request
Feb 7, 2021
Removes also unused *.css from Vue. And Vue 404.html is not using redundant shortcut in link any more as Angular and React are not using. For index.html this PR: * applies the following fixes also for Vue: jhipster#8124, jhipster#10106, jhipster#11817 * uses buildTool variable instead of hardcoded mvnw * removes redundant div with classes lds-css (not existing) and ng-scope (old AngularJS relict) also from Angular and React
kaidohallik
added a commit
to kaidohallik/generator-jhipster
that referenced
this pull request
Feb 7, 2021
Removes also unused *.css from Vue. And Vue 404.html is not using redundant shortcut in link any more as Angular and React are not using. For index.html this PR: * applies the following fixes also for Vue: jhipster#8124, jhipster#10106, jhipster#11817 * uses buildTool variable instead of hardcoded mvnw * removes redundant div with classes lds-css (not existing) and ng-scope (old AngularJS relict) also from Angular and React
5 tasks
coderguy-tech
pushed a commit
to coderguy-tech/generator-jhipster
that referenced
this pull request
Jun 1, 2021
Removes also unused *.css from Vue. And Vue 404.html is not using redundant shortcut in link any more as Angular and React are not using. For index.html this PR: * applies the following fixes also for Vue: jhipster#8124, jhipster#10106, jhipster#11817 * uses buildTool variable instead of hardcoded mvnw * removes redundant div with classes lds-css (not existing) and ng-scope (old AngularJS relict) also from Angular and React
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove 'shortcut' as the link type is non-conforming & ignored
Reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types
Please make sure the below checklist is followed for Pull Requests.
All continuous integration tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed