Correct typos

[vivekmore]

• Please make sure the below checklist is followed for Pull Requests.

• All continuous integration tests are green

• Tests are added where necessary

• Documentation is added/updated where necessary

• Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

[murdos]

The changes in the app subgenerator and in statistics.js are fine IMO, however I think the changes in client and server subgenerators are breaking changes since blueprints could use it.
These changes could probably be postponed to v7

[vivekmore]

Makes sense.
so what do you suggest?
submit PR on separate 7.x branch?

[murdos]

Makes sense.
so what do you suggest?
submit PR on separate 7.x branch?

There's no 7.x branch, we only have maintenance branches.
I've added the 7.x label, I guess the PR will stay open until we start to work on 7.x

[CLAassistant]

All committers have signed the CLA.

[jdubois]

Let's first do the "easy" typos, that are not used by the sub-generators. For the others, it's going to be difficult.

[vivekmore]

Let's first do the "easy" typos, that are not used by the sub-generators. For the others, it's going to be difficult.

How about a gradual upgrade by keeping both variants like follows:

methodWithoutTypo() {
   ...
   // actual code
   ...
}

methodWITHtypo() {
   this.log.warn('Please use methodWithoutTypo() as this method will be deprecated in next major release');
   methodWithoutTypo();
}

[MathieuAA]

@vivekmore that's a good idea! Can you add a comment to the "functions with typos" that says

@deprecated
To be removed for JHipster v7

That way, we could clean them up for the next major

---

edit I should read everything before commenting, seems like you've got the idea :)

[murdos]

Let's first do the "easy" typos, that are not used by the sub-generators. For the others, it's going to be difficult.

These will still be breaking changes, in particular for blueprints.

For example, if a blueprint is overriding a particular step (setupClientconsts in the example below), it won't be overridden anymore if we rename it in main generator to setupClientConstants:

get writing() {
        const phaseFromJHipster = super._writing();
        const customPhaseSteps = {
            setupClientconsts() {
                // Do things that change generator-jhipster behavior...
            },
        };
        return { ...phaseFromJHipster, ...customPhaseSteps };
    }

Development on V7 will start soon, let's wait a bit more and don't break V6 for blueprints (and there're a more and more)

[vivekmore]

@murdos - You're right
However, to get this small PR merged I've removed the breaking changes related to setup*() functions.

I'll make another PR as soon as v7 development starts that:

• removes deprecated methods from this PR
• corrects the setup*() methods (that I removed from my most recent update to this PR)

does that seem reasonable?

[murdos]

I highlighted the 3 remaining breaking changes that should be reverted. Then this PR could be merged ;)

[vivekmore]

I highlighted the 3 remaining breaking changes that should be reverted. Then this PR could be merged ;)

Good catch @murdos ! Sorry for missing these, and thank you for being patient.
I realize I have a few more stuff to learn about things exported from Generators.