Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to generator-jhipster v8 #1537

Merged
merged 75 commits into from
Feb 29, 2024
Merged

Update to generator-jhipster v8 #1537

merged 75 commits into from
Feb 29, 2024

Conversation

hide212131
Copy link
Contributor

@hide212131 hide212131 commented Jan 13, 2024 •
edited
Loading

Fixes #1410

@mraible
Copy link
Contributor

mraible commented Jan 13, 2024

@hide212131 There's a conflict in package-lock.json.

@mshima
Copy link
Member

mshima commented Jan 15, 2024

IMO the best approach is to duplicate ionic blueprint implementation.

@mraible
Copy link
Contributor

mraible commented Jan 29, 2024

@hide212131 There are some conflicts that need to be fixed.

@hide212131
v8 for files under root
c58999c 
Conversion of apps to ES6
@hide212131
fix prompt
50bb1e1
@hide212131
fix loadConfig
4d12fde
@hide212131
Re-implementation of cli and generators/app (with reference to ionic …
6dda68c 
…blueprint)
@hide212131
move templates and resoucces
1c02f2e
@hide212131
adjust yeoman-environment version
26da64e
@hide212131
Re-implementation of generators/project-name
90a3397
@hide212131
fix commands.cjs
d16ec34
@hide212131
adjust generators/app
bf85b75
@hide212131
Re-implementation of generators/react-native
47b7a0d
@hide212131
rename parameter names of templates
5eac40b
@hide212131
adjust loadsh-es
265f9e2
@hide212131
adjust .eslintrc.json
8f68002
@hide212131
add detox prompt
142d579
@hide212131
adjust entity-files
ff11eee
@hide212131
adjust entityPluralFileName
3eb37da
@hide212131
adjust replacePackageJsonVersions
f6f802a
@hide212131
adjust patchNavigationForEntity
63adf99
@hide212131
adjust patchEntityApi
6005c2b
@hide212131
adjust searchEngine
04ea0b6
@hide212131
adjust websocket
4c1a5a3
@hide212131
Workaround for entityPluralFileName 'xxxundefined'
206d8d1
@hide212131
remove old files
3a55f24
@hide212131
adjust patch libs
6b73be6
@hide212131 hide212131 marked this pull request as ready for review February 9, 2024 18:15
@hide212131
Copy link
Contributor Author

Can someone please review and merge?

@mraible
Copy link
Contributor

mraible commented Feb 13, 2024

@hide212131 I did see your request but don't have time to review at the moment.

@DanielFran
Copy link
Member

@hide212131 Can you fix the conflicts?

@mshima
Copy link
Member

mshima commented Feb 24, 2024

We need to adjust merge requirements before this PR.

@mshima
Copy link
Member

mshima commented Feb 25, 2024 •
edited
Loading

The root files need to be reviewed and converted to partial template or removed.
See duplicate prettierrc:
https://github.com/hide212131/generator-jhipster-react-native/blob/7c2a030e344ea67c91d328966a9020bafbba24e7/generators/react-native/__snapshots__/generator.spec.mjs.snap#L26-L30

@mshima
Copy link
Member

mshima commented Feb 25, 2024

The root files I mean are the one generated by init generator:

  • .editorconfig
  • .gitattributes
  • .gitignore
  • .prettierrc.js.ejs

@hide212131
Copy link
Contributor Author

@mshima Thank you for addressing the issue. I have adjusted the rest of the root files.

@mshima mshima merged commit 461a7d9 into jhipster:main Feb 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshima mshima mshima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to JHipster v8
4 participants
@hide212131 @mraible @mshima @DanielFran