Remove buffer-alloc and buffer-from deps
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Buffer.alloc` and `Buffer.from` were added in Node 6. So, this change only drops support for Node 4 and lower, which no one should be running at this point. Especially since Node 6 is already EOL and Node 8 is about to be EOL in December 2019. :) I also removed package-lock.json which is not useful in packages since it doesn't get published to npm. It's existence only ensures that package authors get outdated deps that the users are not going to get.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer.allocandBuffer.fromwere added in Node 6.So, this change only drops support for Node 4 and lower, which no one should be running at this point. Especially since Node 6 is already EOL and Node 8 is about to be EOL in December 2019. :)
I also removed package-lock.json which is not useful in packages since it doesn't get published to npm. It's existence only ensures that package authors get outdated deps that the users are not going to get.
For: brave/brave-browser#5490