Add another error code to the list of unregistered RP errors (Azure#2…

…1606)
jhendrixMSFT · Oct 5, 2023 · 9831d3a · 9831d3a
1 parent 8b62891
commit 9831d3a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/sdk/azcore/CHANGELOG.md b/sdk/azcore/CHANGELOG.md
@@ -12,6 +12,10 @@
 * Added types `KeyCredentialPolicy` and `SASCredentialPolicy` to the `azcore/runtime` package.
   * Includes their respective constructor functions and options types.
 
+### Bugs Fixed
+
+* Fixed an issue that could cause some ARM RPs to not be automatically registered.
+
 ### Other Changes
 
 * The following functions in the `runtime` package are now exposed from the `policy` package, and the `runtime` versions have been deprecated.

diff --git a/sdk/azcore/arm/runtime/policy_register_rp.go b/sdk/azcore/arm/runtime/policy_register_rp.go
@@ -176,6 +176,7 @@ var unregisteredRPCodes = []string{
 	"MissingSubscriptionRegistration",
 	"MissingRegistrationForResourceProvider",
 	"Subscription Not Registered",
+	"SubscriptionNotRegistered",
 }
 
 func isUnregisteredRPCode(errorCode string) bool {

diff --git a/sdk/azcore/arm/runtime/policy_register_rp_test.go b/sdk/azcore/arm/runtime/policy_register_rp_test.go
@@ -414,6 +414,7 @@ func TestRPRegistrationPolicyEnvironmentsInSubExceeded(t *testing.T) {
 
 func TestIsUnregisteredRPCode(t *testing.T) {
 	require.True(t, isUnregisteredRPCode("Subscription Not Registered"))
+	require.True(t, isUnregisteredRPCode("SubscriptionNotRegistered"))
 	require.False(t, isUnregisteredRPCode("Your subscription isn't registered"))
 }