Throw a helpful exception if the AJAX timeout is missing #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mon mistake in the configuration.
…ready being thrown.
pfrenssen
force-pushed
the
throw-helpful-exception-for-ajax-timeout
branch
from
9f34222 to
0f6ed6a
Compare
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #486 (comment) @leevh mentioned that the AJAX timeout won't work if the user has made a mistake in the configuration and used
Behat\MinkExtensioninstead of our overriddenDrupal\MinkExtension.This is a very easy mistake to make, especially when considering that our documentation for versions 3.x and lower of DrupalExtension suggests to use
Behat\MinkExtensioninstead ofDrupal\MinkExtension. This is also suggested in a number of blog posts and stack overflow answers. Also people upgrading from 3.x will likely hit this bug.This can be quite insidious, since everything will seem to work as normal, but when the
@javascripttag is being used then suddenly mysterious failures will pop up: "Unable to complete AJAX request".I suggest to check if the timeout is set, and if not let's throw an exception that can help people on the right path.