Reroll: ajax fix for d7 #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue fixed in #400 breaks the D7 check. Only thing missing is a check if ` Drupal.ajax.instances` actually exists - which is only the case in D8. Without the check we get an error like "Call method some on undefined". While checking the code in D7 I realized we've instances with the ajaxing flag there as well - we just need to access the instances in a different way. I've tried to do that in this change too. So far only tested with a D7 installation.
…peter/drupalextension into das-peter-iWaitForAjaxToFinish-d7-fix
jhedstrom
added a commit
that referenced
this pull request
Dec 4, 2017
…-d7-fix Reroll: ajax fix for d7 Signed-off-by: Jonathan Hedstrom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reroll of #414.