Stop testing on PHP 5.3 #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me once the conflicts are resolved. |
|
Resolved the conflict, this needs a merge before #324 |
|
Thanks @haringsrob! |
|
Once this is in, let's also make a PR to drop PHP 5.4, that also needs to be done before we can merge #324. |
pfrenssen
added a commit
that referenced
this pull request
Jun 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 5.3 has become unsupported years ago. Our test suite has been failing on the 5.3 tests for over a year now. This is slowing down the test runs.
Instead of spending time trying to fix it, let's just remove it from the matrix and move on.