Drupal 7: Implement values array casting in __call() magic method #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hpunit test coverage for that.
| return [ | ||
|
|
||
| // Test default text field provided as simple text. | ||
| [ |
There was a problem hiding this comment.
For now, I'd like to maintain PHP 5.3 compatibility if we can--Drupal 7 still supports that.
|
Sure, here we go! |
|
Any other changes you wish me to have a look at? |
jhedstrom
added a commit
that referenced
this pull request
Mar 23, 2015
Drupal 7: Implement values array casting in __call() magic method
|
Sorry for the delay. Thanks! |
jhedstrom
added a commit
that referenced
this pull request
Mar 23, 2015
Drupal 7: Implement values array casting in __call() magic method Signed-off-by: Jonathan Hedstrom <[email protected]>
|
No problem at all, thanks for the merge! On Mon, Mar 23, 2015 at 7:47 PM, Jonathan Hedstrom <[email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aim to get rid of explicit array-casting in Drupal 7 field handlers in favor of a casting happening in handler abstract class's __call() magic method. It also refactors Drupal 7 field handlers in order to allow object mocking. A basic PHPUnit test coverage with partial mocking by http://docs.mockery.io/ is also provided.